yuanyeex
/
openclaw
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: enforce owner allowlist for commands

main
Gustavo Madeira Santana 2026-02-04 20:05:08 -05:00
parent a6fd76efeb
commit 385a7eba33
2 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/auto-reply/command-auth.ts
View File

@ -204,6 +204,7 @@ export function resolveCommandAuthorization(params: {
ownerCandidatesForCommands.push(...normalizedTo); ownerCandidatesForCommands.push(...normalizedTo);
} }
} }
const ownerAllowAll = ownerAllowFromList.some((entry) => entry.trim() === "*");
const explicitOwners = ownerAllowFromList.filter((entry) => entry !== "*"); const explicitOwners = ownerAllowFromList.filter((entry) => entry !== "*");
const ownerList = Array.from( const ownerList = Array.from(
new Set(explicitOwners.length > 0 ? explicitOwners : ownerCandidatesForCommands), new Set(explicitOwners.length > 0 ? explicitOwners : ownerCandidatesForCommands),
@ -228,11 +229,15 @@ export function resolveCommandAuthorization(params: {
const enforceOwner = Boolean(dock?.commands?.enforceOwnerForCommands); const enforceOwner = Boolean(dock?.commands?.enforceOwnerForCommands);
const senderIsOwner = Boolean(matchedSender); const senderIsOwner = Boolean(matchedSender);
const isOwnerForCommands = const ownerAllowlistConfigured = ownerAllowAll || explicitOwners.length > 0;
!enforceOwner || const requireOwner = enforceOwner || ownerAllowlistConfigured;
allowAll || const isOwnerForCommands = !requireOwner
ownerCandidatesForCommands.length === 0 || ? true
Boolean(matchedCommandOwner); : ownerAllowAll
? true
: ownerAllowlistConfigured
? senderIsOwner
: allowAll || ownerCandidatesForCommands.length === 0 || Boolean(matchedCommandOwner);
const isAuthorizedSender = commandAuthorized && isOwnerForCommands; const isAuthorizedSender = commandAuthorized && isOwnerForCommands;
return { return {

2
src/auto-reply/command-control.test.ts
View File

@ -165,7 +165,7 @@ describe("resolveCommandAuthorization", () => {
commandAuthorized: true, commandAuthorized: true,
}); });
expect(otherAuth.senderIsOwner).toBe(false); expect(otherAuth.senderIsOwner).toBe(false);
expect(otherAuth.isAuthorizedSender).toBe(true); expect(otherAuth.isAuthorizedSender).toBe(false);
}); });
}); });