yuanyeex
/
openclaw
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(browser): derive cdp port from control url

main
Peter Steinberger 2025-12-13 15:16:42 +00:00
parent 208ba02a4a
commit 2d36ae6326
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/browser/config.test.ts
View File

@ -38,6 +38,14 @@ describe("browser config", () => {
expect(shouldStartLocalBrowserServer(resolved)).toBe(false); expect(shouldStartLocalBrowserServer(resolved)).toBe(false);
}); });
it("derives CDP port as control port + 1", () => {
const resolved = resolveBrowserConfig({
controlUrl: "http://127.0.0.1:19000",
});
expect(resolved.controlPort).toBe(19000);
expect(resolved.cdpPort).toBe(19001);
});
it("rejects unsupported protocols", () => { it("rejects unsupported protocols", () => {
expect(() => expect(() =>
resolveBrowserConfig({ controlUrl: "ws://127.0.0.1:18790" }), resolveBrowserConfig({ controlUrl: "ws://127.0.0.1:18790" }),

8
src/browser/config.ts
View File

@ -1,6 +1,5 @@
import type { BrowserConfig } from "../config/config.js"; import type { BrowserConfig } from "../config/config.js";
import { import {
DEFAULT_CLAWD_BROWSER_CDP_PORT,
DEFAULT_CLAWD_BROWSER_COLOR, DEFAULT_CLAWD_BROWSER_COLOR,
DEFAULT_CLAWD_BROWSER_CONTROL_URL, DEFAULT_CLAWD_BROWSER_CONTROL_URL,
DEFAULT_CLAWD_BROWSER_ENABLED, DEFAULT_CLAWD_BROWSER_ENABLED,
@ -55,7 +54,12 @@ export function resolveBrowserConfig(
throw new Error(`browser.controlUrl has invalid port: ${parsed.port}`); throw new Error(`browser.controlUrl has invalid port: ${parsed.port}`);
} }
const cdpPort = DEFAULT_CLAWD_BROWSER_CDP_PORT; const cdpPort = port + 1;
if (cdpPort > 65535) {
throw new Error(
`browser.controlUrl port (${port}) is too high; cannot derive CDP port (${cdpPort})`,
);
}
if (port === cdpPort) { if (port === cdpPort) {
throw new Error( throw new Error(
`browser.controlUrl port (${port}) must not equal CDP port (${cdpPort})`, `browser.controlUrl port (${port}) must not equal CDP port (${cdpPort})`,